We recently refactored the Khan Academy iOS app to use Core Data instead of the haphazard system of JSON files which we were previously using. In this post I’ll explain how to run initialization code that has to happen on the main thread without worrying about race conditions.
When anything in the app needs to access the database, it needs a reference to a Core Data context. Our app shares one main thread context used by all of the UI code, which runs on the main thread. The first time this context is accessed, we need to initialize the persistent store coordinator and the context. Our core data stack class looks something like this:
This is the standard way to initialize an object that may be accessed on multiple threads to ensure that the initialization code runs only once; if two threads reach the
dispatch_once call at the same time, the initialization will happen only once and the second thread will block until the initialization completes.
However, initialization for a Core Data main-queue context has to happen on the main thread or else deadlock can occur. Here, if
[KADefaultStack defaultStack] is called on a background thread before it’s called on the main thread, the initialization will happen on the wrong thread and consequently fail.
My first attempt to fix this was to check within the dispatch block whether we’re on the main thread and if not, dispatch to the main thread to do the initialization:
Unfortunately, there’s a race condition here. If
+ defaultStack is called on a background thread then is called on the main thread immediately after, the main thread’s
dispatch_once will wait for the background thread’s
dispatch_once to finish, but the
dispatch_sync call will wait for the main thread to finish its current run loop, causing deadlock.
I then tried refactoring so that
dispatch_once is always called from the main thread:
Unfortunately, this deadlocks consistently if ever called from the main thread since
dispatch_sync again waits for the main thread to finish, not realizing that we’re already on the main thread.
Our last solution was completely broken but gives us the pieces we need to build a working one. When we’re on the main thread, we want to perform the initialization immediately; when we’re on a background thread we want to dispatch to the main thread then initialize. We can write this logic as follows:
This works, though is inefficient in the common case that we’re fetching the already-initialized stack from a background thread; we’ll end up dispatching to the main thread even if it’s completely unnecessary.
We’d prefer to skip the dispatch_sync call if the initialization has happened already. The static variable
onceToken is set by default to
0 and if we look at the libdispatch source, we can see that it is set to
~0 once the block has run. (Note that
DISPATCH_EXPECT expands to
__builtin_expect, a compiler primitive provided to help with branch prediction.)
We can take advantage of this and write a reusable helper for solving this problem:
With this helper, we can simply call
dispatch_once_on_main_thread instead of
+ defaultStack, and the initialization will always happen on the main thread.
Arguably, setting up Core Data shouldn’t require being on the main thread, but it does as of iOS 7. This helper is useful for this case and others where thread-unsafe initializers need to be run.